terraphim/agent-tasks
16
0
Fork 0
Code Issues 85 Pull Requests Actions Packages Projects Releases Wiki Activity

feat: Wire ForgivingParser into REPL command dispatch #4

New Issue
Open
opened 2026-04-22 09:41:37 +02:00 by product-owner · 0 comments
product-owner commented 2026-04-22 09:41:37 +02:00
Copy Link

Problem Statement

The ForgivingParser module exists with typo tolerance and alias expansion, but ReplCommand::from_str does not use it. Commands like serach (typo) or /q (alias) fail instead of being auto-corrected.

Current State

  • ForgivingParser implemented: crates/terraphim_agent/src/forgiving/parser.rs
  • Default aliases defined: q->search, h->help, etc. in aliases.rs
  • ReplCommand::from_str uses direct string matching in commands.rs
  • No integration between parser and REPL dispatch

Acceptance Criteria

  • ReplCommand::from_str uses ForgivingParser for command matching
  • Typo correction works: serach auto-corrects to search with notification
  • Alias expansion works: /q query expands to /search query
  • Case-insensitive command matching works
  • Auto-correction notifications display in interactive mode
  • Robot mode includes meta.auto_corrected flag in JSON response
  • cargo test -p terraphim_agent passes
  • cargo clippy -- -D warnings passes

Proposed Approach

  1. Modify ReplCommand::from_str in crates/terraphim_agent/src/repl/commands.rs to use ForgivingParser
  2. Handle ParseResult variants (Exact, AliasExpanded, AutoCorrected, Suggestions, Unknown)
  3. Add auto-correction notification in ReplHandler::execute_command
  4. Add auto_corrected flag to robot mode JSON responses

Dependencies

None

Verification

cargo test -p terraphim_agent --lib forgiving::parser::tests
cargo test -p terraphim_agent --test repl_integration_tests
cargo build -p terraphim_agent --features repl
cargo clippy -p terraphim_agent -- -D warnings

Scope

Modifies commands.rs and handler.rs. ~100 lines changed.

Upstream: This issue tracks a feature for terraphim/terraphim-ai

## Problem Statement The `ForgivingParser` module exists with typo tolerance and alias expansion, but `ReplCommand::from_str` does not use it. Commands like `serach` (typo) or `/q` (alias) fail instead of being auto-corrected. ## Current State - `ForgivingParser` implemented: `crates/terraphim_agent/src/forgiving/parser.rs` - Default aliases defined: `q->search`, `h->help`, etc. in `aliases.rs` - `ReplCommand::from_str` uses direct string matching in `commands.rs` - No integration between parser and REPL dispatch ## Acceptance Criteria - [ ] `ReplCommand::from_str` uses `ForgivingParser` for command matching - [ ] Typo correction works: `serach` auto-corrects to `search` with notification - [ ] Alias expansion works: `/q query` expands to `/search query` - [ ] Case-insensitive command matching works - [ ] Auto-correction notifications display in interactive mode - [ ] Robot mode includes `meta.auto_corrected` flag in JSON response - [ ] cargo test -p terraphim_agent passes - [ ] cargo clippy -- -D warnings passes ## Proposed Approach 1. Modify `ReplCommand::from_str` in `crates/terraphim_agent/src/repl/commands.rs` to use `ForgivingParser` 2. Handle `ParseResult` variants (Exact, AliasExpanded, AutoCorrected, Suggestions, Unknown) 3. Add auto-correction notification in `ReplHandler::execute_command` 4. Add `auto_corrected` flag to robot mode JSON responses ## Dependencies None ## Verification ```bash cargo test -p terraphim_agent --lib forgiving::parser::tests cargo test -p terraphim_agent --test repl_integration_tests cargo build -p terraphim_agent --features repl cargo clippy -p terraphim_agent -- -D warnings ``` ## Scope Modifies `commands.rs` and `handler.rs`. ~100 lines changed. Upstream: This issue tracks a feature for terraphim/terraphim-ai
root added a new dependency 2026-04-24 03:05:03 +02:00
#8 feat: Phase 1 robot mode + forgiving parser test suite
root added a new dependency 2026-04-25 06:02:59 +02:00
#31 feat: case-insensitive flags and --flag=value separators (F2.3)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agent-catalogue
Role-based subagent type tracking issue (architect, developer, etc.) — distinct from persona agents (agent:kimiko etc.)
 agent:kairo
Tasks owned by Kairo
 agent:kimiko
Tasks owned by Kimiko
 agent:shimaguru
Tasks owned by Shimaguru
 priority:critical
Must be done immediately
 priority:high
Should be done this cycle
 priority:low
Nice to have
 priority:medium
Normal priority
 status/approved
Approved for implementation
 status/in-progress
Agent is actively working on this issue
 type:bug
Defect fix
 type:feature
New functionality
 type:research
Investigation or spike
 type:task
General task
 workflow:blocked
Task is blocked by a dependency
 workflow:done
Task is complete
 workflow:in-progress
Task is actively being worked on
 workflow:ready
Task is ready for an agent to pick up
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
browser-qa compliance-watchdog documentation-generator drift-detector implementation-swarm kairo kimie05c34be198a20b9 merge-coordinator meta-coordinator product-development quality-coordinator root security-sentinel shimaguru spec-validator upstream-synchronizer
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Blocks
#8 feat: Phase 1 robot mode + forgiving parser test suite
terraphim/agent-tasks
#11 feat: Route REPL command output through machine-readable formatter (Phase 1 Task 1.4.1 and 1.4.3)
terraphim/agent-tasks
#25 feat: Custom command aliases via [aliases] TOML config (F2.2)
terraphim/agent-tasks
#31 feat: case-insensitive flags and --flag=value separators (F2.3)
terraphim/agent-tasks
Reference: terraphim/agent-tasks#4
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?